lostluck commented on pull request #16973: URL: https://github.com/apache/beam/pull/16973#issuecomment-1054912634
Nit: Do add the go fmt changes to the generated code. It's likely just older code that never had it run on it initially, but having automated formatting applied to automatically generated code is a win. As for the reasons why? Where to start? 1. It was only in December when we got rid of the old GoGradle plugin, which didn't have the best support for formatting checks. Invoking by Gradle wasn't clear. 2. Github actions are very new to the project. 3. It's not a huge priority when only 2 engineers were changing the code and were running go fmt (or their editors were) anyway. Should we? Absolutely. Lets do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
