kileys commented on a change in pull request #16609:
URL: https://github.com/apache/beam/pull/16609#discussion_r817988930
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/AutoComplete.java
##########
@@ -467,7 +467,6 @@ public void processElement(ProcessContext c) {
public static void runAutocompletePipeline(Options options) throws
IOException {
- options.setBigQuerySchema(FormatForBigquery.getSchema());
Review comment:
Why are these being removed?
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java
##########
@@ -381,6 +381,13 @@ private QueryResponse queryWithRetries(
/** Creates a new dataset. */
public void createNewDataset(String projectId, String datasetId)
throws IOException, InterruptedException {
+ createNewDataset(projectId, datasetId, null);
+ }
+
+ /** Creates a new dataset with defaultTableExpiration in ms. */
+ public void createNewDataset(
+ String projectId, String datasetId, @Nullable Long
defaultTableExpiration)
Review comment:
```suggestion
String projectId, String datasetId, @Nullable Long
defaultTableExpirationMs)
```
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleIT.java
##########
@@ -1,100 +0,0 @@
-/*
Review comment:
Something wrong with this test?
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -285,8 +285,6 @@ createJavaExamplesArchetypeValidationTask(type:
'Quickstart', runner: 'FlinkLoca
task examplesIntegrationTest(type: Test) {
group = "Verification"
- // Disable gradle cache
- outputs.upToDateWhen { false }
Review comment:
Why is this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
