yeandy commented on a change in pull request #16677:
URL: https://github.com/apache/beam/pull/16677#discussion_r819033329
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -4721,13 +4721,91 @@ def repeat(self, repeats):
pd.core.strings.StringMethods, 'get_dummies',
reason='non-deferred-columns')
- split = frame_base.wont_implement_method(
- pd.core.strings.StringMethods, 'split',
- reason='non-deferred-columns')
+ def _split_helper(
+ self, rsplit=False, pat=None, expand=False, regex=None, **kwargs):
+
+ # Adding arguments to kwargs. regex introduced in pandas 1.4
+ # but only for split, not rsplit
+ kwargs['pat'] = pat
+ kwargs['expand'] = expand
+ if PD_VERSION >= (1, 4) and not rsplit:
+ kwargs['regex'] = regex
+
+ if not expand:
+ # Not creating separate columns
+ proxy = self._expr.proxy()
+ func = lambda s: pd.concat([proxy,
+ (s.str.split(**kwargs) if not rsplit else s.str.rsplit(**kwargs))]
+ )
+ else:
+ # Creating separate columns, so must be more strict on dtype
+ dtype = self._expr.proxy().dtype
+ if not isinstance(dtype, pd.CategoricalDtype):
+ method_name = 'rsplit' if rsplit else 'split'
+ raise frame_base.WontImplementError(
+ method_name + "() of non-categorical type is not supported because
"
Review comment:
Thx, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
