yeandy commented on a change in pull request #16917: URL: https://github.com/apache/beam/pull/16917#discussion_r819105567
########## File path: sdks/python/apache_beam/ml/inference/api.py ########## @@ -0,0 +1,84 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from dataclasses import dataclass +import apache_beam as beam +from typing import Tuple, TypeVar, Union +# TODO: implement RunInferenceImpl +# from apache_beam.ml.inference.base import RunInferenceImpl + + +@dataclass +class BaseModelSpec: + model_url: str + + +@dataclass +class PyTorchModelSpec(BaseModelSpec): Review comment: I know it will be obvious what it can do if you just read the code, but to me, `PyTorchModel` implies that it is the actual model that can do the prediction, instead of an object that holds specs about the model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
