mosche commented on a change in pull request #16987:
URL: https://github.com/apache/beam/pull/16987#discussion_r819472165
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java
##########
@@ -548,12 +554,15 @@ CompleteMultipartUploadResponse multipartCopy(
Math.min(objectSize - 1, bytePosition +
uploadBufferSizeBytes - 1)))
Review comment:
I can't find any good recommendations regarding part sizes of multipart
copy... my gut feeling is that using the max possible we're on the other far
end. But it should be fine.
Have you been able to run some tests against S3 @spatel11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
