tvalentyn commented on a change in pull request #16929:
URL: https://github.com/apache/beam/pull/16929#discussion_r821193813
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -55,15 +55,10 @@
_LOGGER = logging.getLogger(__name__)
-# These options have no dest and action is store_false in the
-# argparse and default is None. When parsing these options in a dict using
-# PipelineOptions,We either ignore/discard if these options are specified.
-# Defining a map with their dest would maintain consistency
-# across PipelineOptions(**dict), PipelineOptions.from_dictionary(dict),
-# and argparse.
-_STORE_FALSE_OPTIONS_WITH_DIFFERENT_DEST = {
- 'use_public_ips': 'no_use_public_ips'
-}
+# Map the boolean option with the flag_name for the flags that have a
Review comment:
Consider the following for readability:
```
# Map of Boolean options to flag names for options that have a
destination(dest)
# in parser.add_argument() different from the flag name
# and whose default value is `None`.
_FLAG_THAT_SETS_FALSE_VALUE = {...}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
