damccorm opened a new pull request #17062:
URL: https://github.com/apache/beam/pull/17062
### Context
Right now, commenting and saving state when handling the
`pull_request_review` and `pull_request_review_comment` events fails when the
pull author is not a committer. This happens because GitHub doesn't allow their
issued token to have any write permissions on forks from non-committers and
there is no way to override that (even #17031 gets overridden on forks
apparently 😢 ). While we're able to get around this for most pull_request
events by using `pull_request_target`, no analogous event exists for
`pull_request_review` and `pull_request_review_comment`.
Fortunately, we don't _need_ to do anything from these events. Right now, on
`pull_request_review` we assign a committer if the review is an approval from a
reviewer. That information can be discovered by looking at all reviews for a pr
during our scheduled run. This is less responsive, but still allows us to get a
committer assigned in <30 minutes.
There's not as good of a workaround for `pull_request_review_comment`, but
we can simply restrict command parsing to the main thread without a significant
impact to user experience.
### Summary of Changes
This PR removes all processing of the `pull_request_review` and
`pull_request_review_comment` events. It doesn't replace the functionality of
`pull_request_review_comment` events, but it does move the logic from
`pull_request_review` events into our scheduled action execution. This was
tested against my test repo and worked. There shouldn't be auth issues since
we're already successfully commenting and updating state from this action.
The biggest diffs in this PR are just moving code from processPrUpdates to
processNewPrs.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
