andoni-guzman commented on a change in pull request #17046:
URL: https://github.com/apache/beam/pull/17046#discussion_r827514635



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -36,7 +36,7 @@ import (
 // TODO(lostluck): 2018/05/28 Extract these from their enum descriptors in the 
pipeline_v1 proto
 const (
        URNImpulse       = "beam:transform:impulse:v1"
-       URNParDo         = "beam:transform:pardo:v1"
+       URNParDo         = "beam:transform:org.apache.beam:pardo:v1"

Review comment:
       Hi @ibzib, the reason that I did in that way is based in this PR 
https://github.com/apache/beam/pull/15748/files 
   This PR Updates cross-language transform URNs to use the new convention and 
solve "Encountered unsupported logical type URN" I don't know why in my local 
tests I didn't catch the new failure.
   If I use the URN "beam:transform:pardo:v1" I got logical type URN error.
   What is the best aprox for this? 
   Maybe only fix dataproc creation and deletion and in a future solve each 
flink tests?
   Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to