VictorPlusC commented on a change in pull request #17072:
URL: https://github.com/apache/beam/pull/17072#discussion_r827532283



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -454,8 +455,12 @@ def record(self, pcolls, max_n, max_duration):
           'options is deprecated since First stable release. References to '
           '<pipeline>.options will not be supported',
           category=DeprecationWarning)
-      pf.PipelineFragment(list(uncomputed_pcolls),

Review comment:
       That is a good idea, thanks! I've added a new unit test for this now 
just to check that the blocking is set to True when we use a GCS cache_root.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to