scwhittle commented on a change in pull request #17094:
URL: https://github.com/apache/beam/pull/17094#discussion_r827738622
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -48,6 +48,8 @@ private MonitoringInfoMetricName(String urn, Map<String,
String> labels) {
// and ensure all necessary labels are set for the specific URN.
this.urn = urn;
for (Entry<String, String> entry : labels.entrySet()) {
+ checkArgument(entry.getKey() != null, "MonitoringInfoMetricName keys
must be non-null");
Review comment:
would it be possible to improve static checking of this by removing the
suppression of the nullness warnings above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
