yeandy commented on a change in pull request #17108:
URL: https://github.com/apache/beam/pull/17108#discussion_r829202873
##########
File path: sdks/python/apache_beam/typehints/schemas_test.py
##########
@@ -91,12 +93,34 @@ def test_typing_survives_proto_roundtrip(self):
test_cases = all_primitives + \
basic_array_types + \
- basic_map_types + \
- selected_schemas
+ basic_map_types
for test_case in test_cases:
self.assertEqual(
- test_case, typing_from_runner_api(typing_to_runner_api(test_case)))
+ test_case, typing_from_runner_api(
+ typing_to_runner_api(test_case,
+ schema_registry=SchemaTypeRegistry()),
+ schema_registry=SchemaTypeRegistry()
+ ))
+
+ for test_case in selected_schemas:
Review comment:
Do we want to break out `selected_schemas` for
`test_proto_survives_typing_roundtrip` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
