lostluck commented on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1072885334
> > Why are we losing the license header on the generated GRPC pb.go files, but not the standard pb.go files? Not really an issue, since we can ignore it in the RAT check, but it is strange. > > TBH I don't know (sad). I saw that and spent some time loosely investigating. I agree that ideally we would have the license header, so I am happy to find some fix before merging! If you have tips on direction or if your google-foo is good, would love any help 🙏🏽 It's most likely an artifact from when you were experiementing and getting things aligned properly. There's nothing that inserts the header into the files, so it should be maintaining the headers through regeneration. At this point, I'd suggest simply re-adding the header texts manually to start, and commit that. Then we can try a re-gen with your scripts, changing nothing else. If they don't get stripped from that process, we know it was an accident as the scripts were being worked on. If they do get stripped, we could also just use the scripts to ensure the header is prefixed onto all the generated Go files. There's a go tool that can do this: https://github.com/google/addlicense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
