lostluck commented on a change in pull request #16957:
URL: https://github.com/apache/beam/pull/16957#discussion_r830418153
##########
File path: sdks/go/pkg/beam/core/runtime/harness/harness.go
##########
@@ -36,14 +36,27 @@ import (
"google.golang.org/grpc"
)
+// StatusAddress is a type of status endpoint address as an optional argument
to harness.Main().
+type StatusAddress string
+
// TODO(herohde) 2/8/2017: for now, assume we stage a full binary (not a
plugin).
// Main is the main entrypoint for the Go harness. It runs at "runtime" -- not
// "pipeline-construction time" -- on each worker. It is a FnAPI client and
// ultimately responsible for correctly executing user code.
-func Main(ctx context.Context, loggingEndpoint, controlEndpoint string) error {
+func Main(ctx context.Context, loggingEndpoint, controlEndpoint string,
options ...interface{}) error {
Review comment:
Agreed this is change we are probably OK with as this is an internal
implementation detail no one should be relying on. I've also checked google3
for that, and the only users are the harness/init and the extworker packages....
Even though it's adding a variadic, it's technically still a breaking change
as it's a type signature change. However, it's not likely to break any odd
callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
