lukecwik commented on a change in pull request #16982:
URL: https://github.com/apache/beam/pull/16982#discussion_r831554704
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/BagUserState.java
##########
@@ -141,6 +141,7 @@ public void asyncClose() throws Exception {
// Modify the underlying cached state depending on the mutations performed
if (isCleared) {
+ // Note this takes ownership of newValues.
Review comment:
```suggestion
// Note this takes ownership of newValues. This object is no longer
used after it has been closed.
```
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/MultimapUserState.java
##########
@@ -317,14 +317,17 @@ private void updateCache() {
}
if (isCleared) {
- // This will clear all keys and values since values is a sub-cache of
keys.
+ // This will clear all keys and values since values is a sub-cache of
keys. Note this
+ // takes ownership of pendingAddKeys.
Review comment:
```suggestion
// takes ownership of pendingAddKeys. This object is no longer used
after it has been closed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
