TheNeuralBit commented on a change in pull request #11074:
URL: https://github.com/apache/beam/pull/11074#discussion_r833635521
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
##########
@@ -130,10 +130,11 @@ private Iterable getIterableValue(FieldType elementType,
Object fieldValue) {
OneOfType oneOfType = type.getLogicalType(OneOfType.class);
OneOfType.Value oneOfValue = (OneOfType.Value) fieldValue;
Object convertedOneOfField =
- getValue(oneOfValue.getFieldType(), oneOfValue.getValue(), null);
- return (T)
- oneOfType.toBaseType(
- oneOfType.createValue(oneOfValue.getCaseType(),
convertedOneOfField));
+ getValue(oneOfType.getFieldType(oneOfValue),
oneOfValue.getValue(), null);
+ return (T) oneOfType.createValue(oneOfValue.getCaseType(),
convertedOneOfField);
+ } else if (type.getTypeName().isLogicalType()) {
+ // Getters are assumed to return the base type.
+ return (T) type.getLogicalType().toInputType(fieldValue);
Review comment:
Alternatively, I wonder if we could we add a way to register getters
that are assumed to return the input type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
