damccorm commented on a change in pull request #17045:
URL: https://github.com/apache/beam/pull/17045#discussion_r834696183



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/v1/v1.pb.go
##########
@@ -212,18 +212,19 @@ const (
        Type_CONTEXT Type_Special = 2
        Type_TYPE    Type_Special = 3
        // Beam
-       Type_EVENTTIME     Type_Special = 10
-       Type_WINDOW        Type_Special = 22
-       Type_KV            Type_Special = 11
-       Type_COGBK         Type_Special = 13
-       Type_WINDOWEDVALUE Type_Special = 14
-       Type_T             Type_Special = 15
-       Type_U             Type_Special = 16
-       Type_V             Type_Special = 17
-       Type_W             Type_Special = 18
-       Type_X             Type_Special = 19
-       Type_Y             Type_Special = 20
-       Type_Z             Type_Special = 21
+       Type_EVENTTIME          Type_Special = 10
+       Type_WINDOW             Type_Special = 22
+       Type_KV                 Type_Special = 11
+       Type_COGBK              Type_Special = 13
+       Type_WINDOWEDVALUE      Type_Special = 14
+       Type_BUNDLEFINALIZATION Type_Special = 23

Review comment:
       @lostluck thoughts on taking this now? It will cause a merge conflict, 
but its inevitable that one of our prs will run into that and this one is ready 
to go (I think, obviously feel free to review/disagree), and that one has been 
hanging around for a bit. Would be nice to doc/finish this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to