reuvenlax commented on a change in pull request #17187:
URL: https://github.com/apache/beam/pull/17187#discussion_r835654079
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
##########
@@ -173,6 +173,12 @@ public DestinationState(
this.useDefaultStream = useDefaultStream;
}
+ void teardown() {
+ if (streamAppendClient != null) {
+ runAsyncIgnoreFailure(closeWriterExecutor,
streamAppendClient::unpin);
Review comment:
No - unpin will only close the connection if close() has already been
called. Since the client is still healthy, we can leave it in the cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
