chamikaramj commented on a change in pull request #17051: URL: https://github.com/apache/beam/pull/17051#discussion_r836592798
########## File path: sdks/java/io/cdap/src/main/java/org/apache/beam/sdk/io/cdap/PluginConfigInstantiationUtils.java ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.cdap; + +import io.cdap.cdap.api.annotation.Name; +import io.cdap.cdap.api.plugin.PluginConfig; +import java.lang.reflect.Constructor; +import java.lang.reflect.Field; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Modifier; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import javax.annotation.Nullable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Class for getting any filled {@link io.cdap.cdap.api.plugin.PluginConfig} configuration object. + */ +@SuppressWarnings({"unchecked", "assignment.type.incompatible"}) +public class PluginConfigInstantiationUtils { + + private static final Logger LOG = LoggerFactory.getLogger(PluginConfigInstantiationUtils.class); + + /** + * @param params map of config fields, where key is the name of the field, value must be String or + * boxed primitive + * @return Config object for given map of arguments and configuration class + */ + public static @Nullable <T extends PluginConfig> T getPluginConfig( + Map<String, Object> params, Class<T> configClass) { + // Validate configClass + if (configClass == null || configClass.isPrimitive() || configClass.isArray()) { + throw new IllegalArgumentException("Config class must be correct!"); + } + List<Field> allFields = new ArrayList<>(); + Class<?> currClass = configClass; + while (currClass != null && !currClass.equals(Object.class)) { + allFields.addAll( + Arrays.stream(currClass.getDeclaredFields()) + .filter( + f -> !Modifier.isStatic(f.getModifiers()) && f.isAnnotationPresent(Name.class)) + .collect(Collectors.toList())); + currClass = currClass.getSuperclass(); + } + T config = getEmptyObjectOf(configClass); + + if (config != null) { + for (Field field : allFields) { + field.setAccessible(true); + + Class<?> fieldType = field.getType(); + + Name declaredAnnotation = field.getDeclaredAnnotation(Name.class); + Object fieldValue = + declaredAnnotation != null ? params.get(declaredAnnotation.value()) : null; + + if (fieldValue != null && fieldType.equals(fieldValue.getClass())) { + try { + field.set(config, fieldValue); + } catch (IllegalAccessException e) { + LOG.error("Can not set a field", e); + } + } + } + } + return config; + } + + /** @return empty {@link Object} of {@param tClass} */ + private static @Nullable <T> T getEmptyObjectOf(Class<T> tClass) { + for (Constructor<?> constructor : tClass.getDeclaredConstructors()) { + constructor.setAccessible(true); Review comment: Should we add public constructors to those classes instead of trying to use private once which might disappear since they are not a part of the public API ? ########## File path: sdks/java/io/cdap/src/main/java/org/apache/beam/sdk/io/cdap/PluginConfigInstantiationUtils.java ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.cdap; + +import io.cdap.cdap.api.annotation.Name; +import io.cdap.cdap.api.plugin.PluginConfig; +import java.lang.reflect.Constructor; +import java.lang.reflect.Field; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Modifier; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import javax.annotation.Nullable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Class for getting any filled {@link io.cdap.cdap.api.plugin.PluginConfig} configuration object. + */ +@SuppressWarnings({"unchecked", "assignment.type.incompatible"}) +public class PluginConfigInstantiationUtils { + + private static final Logger LOG = LoggerFactory.getLogger(PluginConfigInstantiationUtils.class); + + /** + * @param params map of config fields, where key is the name of the field, value must be String or + * boxed primitive + * @return Config object for given map of arguments and configuration class + */ + public static @Nullable <T extends PluginConfig> T getPluginConfig( + Map<String, Object> params, Class<T> configClass) { + // Validate configClass + if (configClass == null || configClass.isPrimitive() || configClass.isArray()) { + throw new IllegalArgumentException("Config class must be correct!"); + } + List<Field> allFields = new ArrayList<>(); + Class<?> currClass = configClass; + while (currClass != null && !currClass.equals(Object.class)) { + allFields.addAll( + Arrays.stream(currClass.getDeclaredFields()) + .filter( + f -> !Modifier.isStatic(f.getModifiers()) && f.isAnnotationPresent(Name.class)) + .collect(Collectors.toList())); + currClass = currClass.getSuperclass(); + } + T config = getEmptyObjectOf(configClass); + + if (config != null) { + for (Field field : allFields) { + field.setAccessible(true); + + Class<?> fieldType = field.getType(); + + Name declaredAnnotation = field.getDeclaredAnnotation(Name.class); + Object fieldValue = + declaredAnnotation != null ? params.get(declaredAnnotation.value()) : null; + + if (fieldValue != null && fieldType.equals(fieldValue.getClass())) { + try { + field.set(config, fieldValue); + } catch (IllegalAccessException e) { + LOG.error("Can not set a field", e); + } + } + } + } + return config; + } + + /** @return empty {@link Object} of {@param tClass} */ + private static @Nullable <T> T getEmptyObjectOf(Class<T> tClass) { + for (Constructor<?> constructor : tClass.getDeclaredConstructors()) { Review comment: Are you looking for the first constructor or the default constructor (without parameters) ? ########## File path: sdks/java/io/cdap/build.gradle ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +plugins { + id 'java' + id 'org.apache.beam.module' +} + +applyJavaNature( + exportJavadoc: false, + automaticModuleName: 'org.apache.beam.sdk.io.cdap', +) +provideIntegrationTestingDependencies() +enableJavaPerformanceTesting() + +description = "Apache Beam :: CDAP :: Java" +ext.summary = """Apache Beam SDK provides a simple, Java-based +interface for integration with CDAP plugins.""" + +/** Define the list of runners which execute a precommit test. + * Some runners are run from separate projects, see the preCommit task below + * for details. + */ + +allprojects { + repositories { + maven { url 'https://jitpack.io' } Review comment: Should we wait till dependency issue is resolved before committing the code ? How would this work for release Beam ? Sounds like this just builds a local SNAPSHOT jar and probably not good as a permanent dependency for Beam. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
