reuvenlax commented on a change in pull request #17070:
URL: https://github.com/apache/beam/pull/17070#discussion_r836805875
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiDynamicDestinationsTableRow.java
##########
@@ -91,9 +95,32 @@ public Descriptor getSchemaDescriptor() {
}
@Override
- public Message toMessage(T element) {
- return TableRowToStorageApiProto.messageFromTableRow(
- descriptor, formatFunction.apply(element));
+ public Message toMessage(T element) throws Exception {
Review comment:
End up having to add a list of about 4 exceptions if I specify them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
