benWize commented on pull request #15549: URL: https://github.com/apache/beam/pull/15549#issuecomment-1081092783
> Hi @pabloem, I'm working on the fixes for this PR, I found out that the new errors like https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/21582/testReport/junit/org.apache.beam.sdk.io.redis/RedisIOTest/testRead/ are related to the use of `Latest.perKey()`. The failing case for that combineFn happen when the elements in the PCollection don't contain timestamped values, so a timestamp is added in https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Latest.java#L188, and the condition in https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Latest.java#L110 return the accumulator with a null value, so when tries to encode produces the reported failure in the tests. I'm not sure if we need to add something else to RedisIO transform, or Latest combineFn should be modified to include that specific case. Adding a case in `Latest` to handle accumulator and input with the same timestamp and one of those with a value different than null could solve the problem https://github.com/apache/beam/pull/15549/commits/3ccfe8ad459b644a2c5ecb80c8d9959351b2d94c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
