mosche opened a new pull request #17203: URL: https://github.com/apache/beam/pull/17203
(PR just for reference, not meant to be merged) JMH benchmarks on reading field values from `RowWithGetters`. This is meant to establish a baseline for the current code on master. [Here's a visualization](https://jmh.morethan.io/?sources=https://raw.githubusercontent.com/apache/beam/3b5e1d607d30397abb27a119fc30c5d05a7b2d40/sdks/java/harness/jmh/RowWithGetters-master-cache-disabled.json,https://raw.githubusercontent.com/apache/beam/3b5e1d607d30397abb27a119fc30c5d05a7b2d40/sdks/java/harness/jmh/RowWithGetters-master-cache-enabled-lazy-init.json) of the results for master comparing two benchmark runs reading field values once & three times with * caching disabled. * caching enabled (using lazy initialisation of the cache data structure). NOTE: * The score doesn't reflect read access only, measurement includes iterating over a large number of rows. What matters are the relative changes. * You cannot easily compare scores between different benchmarks as rows contain different number of fields. Also, depending on types, fields are read recursively to measure the impact of lazy vs eager data structures. * Any cache initialization is done lazily on first read (if caching is enabled) to include associated costs in the measurement. Each benchmark method invocation processes a bundle of 50k rows and recursively reads all values per row. The rows are created upfront using JMH `State` to exclude any initialization costs from the measurement. To prevent unintended cache hits in `RowWithGetters` a new bundle of rows must be generated before every invocation. Using state setup per `Level#Invocation` has significant drawbacks by itself! Though, given that reading bundles of 50k rows takes well above 1 ms, each individual invocation can be adequately timestamped without risking generating wrong results. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
