echauchot commented on a change in pull request #16953:
URL: https://github.com/apache/beam/pull/16953#discussion_r837383869
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -203,7 +202,9 @@
})
public class ElasticsearchIO {
Review comment:
please remove all leftover references to shardPreference, it was an ES2
only code
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -2551,6 +2554,15 @@ public void closeClient() throws IOException {
}
}
+ private static void maybeLogVersionDeprecationWarning(int clusterVersion) {
+ if (DEPRECATED_CLUSTER_VERSIONS.contains(clusterVersion)) {
+ LOG.warn(
+ "Support for cluster version {} will be dropped in a future release
of the "
Review comment:
sed s/cluster/Elasticsearch cluster/g
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
