tvalentyn commented on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1082549553
Thanks for taking on this change, @thempatel . The new suggested import aliases for Python (`proto_file_name.message_name`, such as `beam_runner_api_pb2.SideInput`) sounds good to me. It also does not preclude from using the fully-qualified import path if someone would like that. For further steps on this PR I'd suggest to cleanup the commit history if comments from other reviewers have been addressed. Please do keep separate commit(s) for tooling changes, for regenerated stubs and fixes in the code to use new namespaces. I think it would be useful to break it down instead of all squashing into one change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
