lukecwik commented on code in PR #17243:
URL: https://github.com/apache/beam/pull/17243#discussion_r842156693
##########
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/channel/ManagedChannelFactory.java:
##########
@@ -89,6 +89,11 @@ public ManagedChannel forDescriptor(ApiServiceDescriptor
apiServiceDescriptor) {
// Set the message size to max value here. The actual size is
governed by the
// buffer size in the layers above.
.maxInboundMessageSize(Integer.MAX_VALUE)
+ // Disable automatic retries as it introduces complexity and we
send long-lived
+ // rpcs which will exceed the per-rpc retry request buffer and not
be retried
+ // anyway. See
+ //
https://github.com/grpc/proposal/blob/master/A6-client-retries.md#when-retries-are-valid
Review Comment:
```suggestion
// Disable automatic retries as it introduces complexity and we
send long-lived
// rpcs which will exceed the per-rpc retry request buffer and
not be retried
// anyway. See
//
https://github.com/grpc/proposal/blob/master/A6-client-retries.md#when-retries-are-valid
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
