mosche commented on code in PR #17113: URL: https://github.com/apache/beam/pull/17113#discussion_r844920584
########## sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/ClientPool.java: ########## @@ -1,123 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.beam.sdk.io.aws2.common; - -import java.util.function.BiFunction; -import org.apache.beam.sdk.io.aws2.options.AwsOptions; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.BiMap; -import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.HashBiMap; -import org.apache.commons.lang3.tuple.Pair; -import org.checkerframework.checker.nullness.qual.Nullable; -import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; - -/** - * Reference counting pool to easily share AWS clients or similar by individual client provider and - * configuration (optional). - * - * <p>NOTE: This relies heavily on the implementation of {@link #equals(Object)} for {@link - * ProviderT} and {@link ConfigT}. If not implemented properly, clients can't be shared between - * instances of {@link org.apache.beam.sdk.transforms.DoFn}. - * - * @param <ProviderT> Client provider - * @param <ConfigT> Optional, nullable configuration - * @param <ClientT> Client - */ -public class ClientPool<ProviderT, ConfigT, ClientT extends AutoCloseable> { Review Comment: It's purely internal and never exposed anywhere on a user facing API. So this won't break anything. It needs to be public as used outside this package in the IOs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
