nbali commented on PR #16888: URL: https://github.com/apache/beam/pull/16888#issuecomment-1095584747
It seemed to work, but I have to admit I only tested my use-cases and I did not perform a thorough regression test. Anyway lets assume the worst so the replacement was there for a reason, and there are cases where it doesn't work properly. In that case as I mentioned in https://github.com/apache/beam/pull/16888#issuecomment-1067548642 I can completely do the opposite and instead of the current "silently replacing SDF with Legacy" and the proposed "not overriding the SDF version with the Legacy az all", it could throw an exception if SDF implementation is being picked with v1 runner. Trully doesn't matter IMO. Just please avoid replacing it quietly as that is such a debugging nightmare. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
