ihji commented on code in PR #17249:
URL: https://github.com/apache/beam/pull/17249#discussion_r847789517
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java:
##########
@@ -71,6 +72,7 @@
@Experimental(Kind.PORTABILITY)
@SuppressWarnings({
"rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+ "keyfor",
Review Comment:
Done.
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java:
##########
@@ -263,9 +268,11 @@ public OutputT expand(InputT input) {
return toOutputCollection(outputMapBuilder.build());
}
- private RunnerApi.Components resolveArtifacts(RunnerApi.Components
components) {
- if (components.getEnvironmentsMap().values().stream()
- .allMatch(env -> env.getDependenciesCount() == 0)) {
+ private RunnerApi.Components resolveArtifacts(
+ RunnerApi.Components components, Set<String> originalEnvIds) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
