KevinGG commented on PR #17351: URL: https://github.com/apache/beam/pull/17351#issuecomment-1097102158
> > because the order of accessing entries in a dict is non-deterministic. > > Note that Python dictionaries are [ordered since Python 3.6](https://stackoverflow.com/questions/39980323/are-dictionaries-ordered-in-python-3-6) - I don't think this is the root cause. Yes, you are right. I just checked some CPython source [code](https://github.com/python/cpython/blob/474fdbe9e4a2ff90ef39e8748da644c86a200981/Lib/typing.py#L269)  So the deduplication logic when building a Union type accesses parameters through a set. And since set is not ordered, this is where the flakiness come. I'll update the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
