emilymye commented on code in PR #17274:
URL: https://github.com/apache/beam/pull/17274#discussion_r849046219
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -117,8 +121,12 @@ public static JavaVersion forSpecification(String
specification) {
return ver;
}
}
- throw new UnsupportedOperationException(
- String.format("unsupported Java version: %s", specification));
+ JavaVersion fallback = java11;
Review Comment:
Could we have two methods here, where one is "getJavaVersionOrDefault" or
similar? There are some cases where we probably want to have a strict check
(i.e. expecting translatation from one of the existing enums, looking for a
specific supported Docker container version where defaulting can lead to
confusing behavior)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
