reuvenlax commented on code in PR #17070:
URL: https://github.com/apache/beam/pull/17070#discussion_r849638886


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -1013,4 +1018,28 @@ public static ServiceCallMetric 
readCallMetric(TableReference tableReference) {
   public static ServiceCallMetric writeCallMetric(TableReference 
tableReference) {
     return callMetricForMethod(tableReference, "BigQueryBatchWrite");
   }
+
+  /**
+   * Hashes a schema descriptor using a deterministic hash function.
+   *
+   * <p>Warning! These hashes are encoded into messages, so changing this 
function will cause
+   * pipelines to get stuck on update!
+   */
+  public static long hashSchemaDescriptorDeterministic(Descriptor descriptor) {

Review Comment:
   yeah - the risk is adding fields that are not stable (since this is a 
dynamically-generated proto). I'll take another look through to make sure I 
didn't forget anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to