pabloem commented on code in PR #17354: URL: https://github.com/apache/beam/pull/17354#discussion_r849877962
########## .test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties +import PostcommitJobBuilder + +import static PythonTestProperties.ALL_SUPPORTED_VERSIONS Review Comment: let's make sure that these tests run on a schedule (maybe every 12 hours or so) ########## sdks/python/test-suites/dataflow/common.gradle: ########## @@ -124,6 +124,30 @@ task postCommitIT { } } +task postCommitSickbay { + dependsOn 'installGcpTest' + dependsOn ':sdks:python:sdist' + dependsOn ':runners:google-cloud-dataflow-java:worker:shadowJar' + + def dataflowWorkerJar = project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath Review Comment: I don't think we need this. I'd like to run these on Runner V2 only. Do you know how to set this up as a Runner V2 test? ########## sdks/python/apache_beam/io/gcp/gcsio_integration_test.py: ########## @@ -121,8 +121,9 @@ def test_copy_kms(self): raise unittest.SkipTest('--kms_key_name not specified') self._test_copy("test_copy_kms", self.kms_key_name) - @pytest.mark.it_postcommit - @unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again') + @pytest.mark.it_postcommit_sickbay + #@pytest.mark.it_postcommit Enable when this test is not more sickbay + #@unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again') Review Comment: ditto ########## sdks/python/apache_beam/io/gcp/gcsio_integration_test.py: ########## @@ -175,8 +176,9 @@ def test_copy_batch_kms(self): raise unittest.SkipTest('--kms_key_name not specified') self._test_copy_batch("test_copy_batch_kms", self.kms_key_name) - @pytest.mark.it_postcommit - @unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again') + @pytest.mark.it_postcommit_sickbay + #@pytest.mark.it_postcommit Enable when this test is not sickbay + #@unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again') Review Comment: remove the unittest.skip line please? but leave BEAM-12352 in a comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
