TheNeuralBit commented on code in PR #17253: URL: https://github.com/apache/beam/pull/17253#discussion_r849931279
########## sdks/python/apache_beam/utils/windowed_value.pxd: ########## @@ -43,6 +43,14 @@ cdef class WindowedValue(object): cpdef WindowedValue with_value(self, new_value) [email protected] Review Comment: Ack I removed this from this PR. What does it mean to make it an interface? Just drop the `@cython.final`? (sorry my knowledge of cython is very limited :sweat_smile:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
