ihji commented on code in PR #17280:
URL: https://github.com/apache/beam/pull/17280#discussion_r850711768
##########
sdks/python/apache_beam/runners/portability/expansion_service.py:
##########
@@ -63,6 +64,10 @@ def with_pipeline(component, pcoll_id=None):
}
transform = with_pipeline(
ptransform.PTransform.from_runner_api(request.transform, context))
+ if request.output_coder_override.spec.urn:
+ output_coder = Coder.from_runner_api(
+ request.output_coder_override, context)
+ transform = transform.with_output_types(output_coder.to_type_hint())
Review Comment:
looks like we're already doing type compatibility check during transform
application to pipeline:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/pipeline.py#L711
Incompatible output type assignment will throw an error at
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/expansion_service.py#L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
