nausharipov commented on code in PR #17205:
URL: https://github.com/apache/beam/pull/17205#discussion_r851117062
##########
website/www/site/assets/js/quotes-slider.js:
##########
@@ -10,33 +10,32 @@
// License for the specific language governing permissions and limitations
under
// the License.
-var slider = new KeenSlider("#my-keen-slider", {
- loop: true,
- created: function (instance) {
- var dots_wrapper = document.getElementById("dots");
- var slides = document.querySelectorAll(".keen-slider__slide");
- slides.forEach(function (t, idx) {
- var dot = document.createElement("button");
- dot.classList.add("dot");
- dots_wrapper.appendChild(dot);
- dot.addEventListener("click", function () {
- instance.moveToSlide(idx);
- });
- });
- updateClasses(instance);
- },
- slideChanged(instance) {
- updateClasses(instance);
+$(document).ready(function(){
+ const SelectorNames = {
Review Comment:
I think using strings without constants like SelectorNames increases
readability in this case:
`$('.slick-JS').slick({`
...
`appendDots: '.dots-wrapper',
`dotsClass: 'dots',`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
