RustedBones commented on code in PR #16271:
URL: https://github.com/apache/beam/pull/16271#discussion_r851170588
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroGenericCoder.java:
##########
@@ -18,15 +18,31 @@
package org.apache.beam.sdk.coders;
import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericDatumReader;
+import org.apache.avro.generic.GenericDatumWriter;
import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.io.DatumReader;
+import org.apache.avro.io.DatumWriter;
/** AvroCoder specialisation for GenericRecord. */
public class AvroGenericCoder extends AvroCoder<GenericRecord> {
- AvroGenericCoder(Schema schema) {
+
+ public AvroGenericCoder(Schema schema) {
Review Comment:
Constructor need to be accessed from `AvroCoder` and users should be able to
extends the class to create their own coder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
