chamikaramj commented on PR #16888: URL: https://github.com/apache/beam/pull/16888#issuecomment-1103188631
I think we wanted to not fork SDK code based on the Dataflow Runner version. Hence the reason for the override in DataflowRunner.java (which is not strictly SDK). @kennknowles has more context on this refactoring. I think we want to keep the non-SDF version for Runner v1 since SDF on Runner v1 does not support some Dataflow features appropriately. These I believe were the reasons for the current strange way of using SDF in the SDK and overriding for Runner v1. I don't think either removing the override or forking the SDK is appropriate. May be we can update Java docs or Beam Website documentation to explain this better ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
