tvalentyn commented on code in PR #17300: URL: https://github.com/apache/beam/pull/17300#discussion_r854428337
########## website/www/site/content/en/documentation/resources/learning-resources.md: ########## @@ -97,8 +97,7 @@ If you have additional material that you would like to see here, please let us k ### Python -* **[Python Qwik Start](https://qwiklabs.com/focuses/1100?locale=en&parent=catalog)** (30m) - Run a word count pipeline on the Dataflow runner. -* **[NDVI from Landsat Images](https://qwiklabs.com/focuses/1849?locale=en&parent=catalog)** (45m) - Process Landsat satellite data in a distributed environment to compute the [Normalized Difference Vegetation Index](https://en.wikipedia.org/wiki/Normalized_difference_vegetation_index) (NDVI). +* **[Python Qwik Start](https://www.qwiklabs.com/focuses/1098?parent=catalog)** (30m) - Run a word count pipeline on the Dataflow runner. Review Comment: not sure what's the difference in the urls for the first link; both ...1098... and ...1100... work for me (after signing in with Qwiklabs). the removed `NDVI from Landsat Images` link did not work, indeed. ########## website/www/site/content/en/documentation/sdks/go.md: ########## @@ -28,7 +28,7 @@ This means worker binaries may need to be [cross-compiled](/documentation/sdks/g Get started with the [Beam Go SDK quickstart](/get-started/quickstart-go) to set up your development environment and run an example pipeline. Then, read through the [Beam programming guide](/documentation/programming-guide) to learn the basic concepts that apply to all SDKs in Beam. -See the [godoc](https://pkg.go.dev/github.com/apache/beam/sdks/v2/go/pkg/beam) for more detailed information. +See the [godoc](https://pkg.go.dev/github.com/apache/beam/sdks/go/pkg/beam) for more detailed information. Review Comment: What's the reason for this change? Both links work. I think v2 refers to documentation for newer SDKs and will be used going forward. ########## website/www/site/content/en/blog/review-input-streaming-connectors.md: ########## @@ -184,15 +184,15 @@ and <a href="https://spark.apache.org/docs/latest/api/python/pyspark.streaming.h </td> <td>N/A </td> - <td><a href="https://spark.apache.org/docs/latest/api/python/pyspark.streaming.html#pyspark.streaming.kafka.KafkaUtils";>KafkaUtils</a> + <td><a href="https://spark.apache.org/docs/latest/streaming-kafka-0-10-integration.html";>KafkaUtils</a> Review Comment: this is an old blog and the info is outdated. @rszper you could perhaps reference older version of pyspark to preserve the original narrative. https://spark.apache.org/docs/2.4.8/api/python/pyspark.streaming.html#pyspark.streaming.kafka.KafkaUtils ########## website/www/site/content/en/documentation/runtime/environments.md: ########## @@ -102,7 +102,7 @@ This method requires building image artifacts from Beam source. For additional i git checkout origin/release-$BEAM_SDK_VERSION ``` -2. Customize the `Dockerfile` for a given language, typically `sdks/<language>/container/Dockerfile` directory (e.g. the [Dockerfile for Python](https://github.com/apache/beam/blob/master/sdks/python/container/Dockerfile). If you're adding dependencies from [PyPI](https://pypi.org/), use [`base_image_requirements.txt`](https://github.com/apache/beam/blob/master/sdks/python/container/base_image_requirements.txt) instead. +2. Customize the `Dockerfile` for a given language, typically `sdks/<language>/container/Dockerfile` directory (e.g. the [Dockerfile for Python](https://github.com/apache/beam/blob/master/sdks/python/container/Dockerfile). If you're adding dependencies from [PyPI](https://pypi.org/), use [`base_image_requirements.txt`](https://github.com/apache/beam/blob/master/sdks/python/container/py38/base_image_requirements.txt) instead. Review Comment: Let's remove If you're adding ... sentence. ########## website/www/site/content/en/blog/review-input-streaming-connectors.md: ########## @@ -184,15 +184,15 @@ and <a href="https://spark.apache.org/docs/latest/api/python/pyspark.streaming.h </td> <td>N/A </td> - <td><a href="https://spark.apache.org/docs/latest/api/python/pyspark.streaming.html#pyspark.streaming.kafka.KafkaUtils";>KafkaUtils</a> + <td><a href="https://spark.apache.org/docs/latest/streaming-kafka-0-10-integration.html";>KafkaUtils</a> </td> </tr> <tr> <td>Kinesis </td> <td>N/A </td> - <td><a href="https://spark.apache.org/docs/latest/api/python/pyspark.streaming.html#module-pyspark.streaming.kinesis";>KinesisUtils</a> + <td><a href="https://spark.apache.org/docs/latest/api/python/reference/api/pyspark.streaming.kinesis.KinesisUtils.createStream.html";>KinesisUtils</a> Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
