miamihotline commented on code in PR #17226:
URL: https://github.com/apache/beam/pull/17226#discussion_r854488354
##########
playground/frontend/lib/modules/examples/repositories/models/get_example_request.dart:
##########
@@ -23,4 +23,14 @@ class GetExampleRequestWrapper {
final SDK sdk;
GetExampleRequestWrapper(this.path, this.sdk);
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetExampleRequestWrapper &&
+ path == other.path &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => path.hashCode ^ sdk.hashCode;
Review Comment:
Hello, @KonradJanica! Thank you for the review, fixed that in the last
commit.
##########
playground/frontend/lib/modules/examples/repositories/models/get_list_of_examples_request.dart:
##########
@@ -23,4 +23,14 @@ class GetListOfExamplesRequestWrapper {
final String? category;
GetListOfExamplesRequestWrapper({required this.sdk, required this.category});
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetListOfExamplesRequestWrapper &&
+ category == other.category &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => category.hashCode ^ sdk.hashCode;
Review Comment:
Hello, @KonradJanica! Thank you for the review, fixed that in the last
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
