chamikaramj commented on code in PR #17418:
URL: https://github.com/apache/beam/pull/17418#discussion_r856943846
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/ExternalPythonTransform.java:
##########
@@ -65,8 +66,10 @@
private @Nullable Object @NonNull [] argsArray;
private @Nullable Row providedKwargsRow;
- private ExternalPythonTransform(String fullyQualifiedName, int
expansionPort) {
+ private ExternalPythonTransform(
+ String fullyQualifiedName, String expansionHost, int expansionPort) {
Review Comment:
Still unsure shy the API is different from Python where we take a single
"expansion_service" address:
https://github.com/apache/beam/blob/3f2e3c7c9eccb9d40370cbc70e9a451a4b5573f5/sdks/python/apache_beam/transforms/external.py#L417
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/ExternalPythonTransform.java:
##########
@@ -268,20 +268,31 @@ public OutputT expand(InputT input) {
Row argsRow = buildOrGetArgsRow();
Row kwargsRow = buildOrGetKwargsRow();
try {
- Schema payloadSchema =
- Schema.of(
- Schema.Field.of("constructor", Schema.FieldType.STRING),
- Schema.Field.of("args",
Schema.FieldType.row(argsRow.getSchema())),
- Schema.Field.of("kwargs",
Schema.FieldType.row(kwargsRow.getSchema())));
+ Schema.Builder schemaBuilder = Schema.builder();
+ schemaBuilder.addStringField("constructor");
+ if (argsRow.getValues().size() > 0) {
+ schemaBuilder.addRowField("args", argsRow.getSchema());
+ }
+ if (kwargsRow.getValues().size() > 0) {
+ schemaBuilder.addRowField("kwargs", kwargsRow.getSchema());
+ }
+ Schema payloadSchema = schemaBuilder.build();
payloadSchema.setUUID(UUID.randomUUID());
- Row payloadRow =
- Row.withSchema(payloadSchema).addValues(fullyQualifiedName, argsRow,
kwargsRow).build();
+ Row.Builder payloadRowBuilder = Row.withSchema(payloadSchema);
+ payloadRowBuilder.addValue(fullyQualifiedName);
+ if (argsRow.getValues().size() > 0) {
Review Comment:
Please add a comment and a unit test so that this doesn't get broken by a
future change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
