brachi-wernick commented on code in PR #15699: URL: https://github.com/apache/beam/pull/15699#discussion_r858430584
########## sdks/java/core/src/test/java/org/apache/beam/sdk/io/fs/MetadataDynamicCoderTest.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.fs; + +import java.nio.file.Path; +import org.apache.beam.sdk.coders.VarLongCoder; +import org.apache.beam.sdk.io.FileSystems; +import org.apache.beam.sdk.io.fs.MatchResult.Metadata; +import org.apache.beam.sdk.testing.CoderProperties; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +/** Tests for {@link org.apache.beam.sdk.io.fs.MetadataDynamicCoder}. */ +public class MetadataDynamicCoderTest { + + @Rule public transient TemporaryFolder tmpFolder = new TemporaryFolder(); + + @Test + public void testEncodeDecodeWithDefaultLastModifiedMills() throws Exception { Review Comment: Kind problematic, since all fields now in Metadata are handled. except the one that I used in the test. It can work if I won't use the basic `MetadataCoder` in this dynamic coder, and work only with the fields coders I get in the list, But I think it will be mess to developers to assign all these basic fields for the dynamic coder, it is easy now, that they need to send only new/special fields and not all the basic fields. (coder now first does : `MatchResult.Metadata.Builder builder = V1_CODER.decodeBuilder(inStream);` which covers most of the fields in Metadata. and new fields will be covered with this coder list of {coder,getter,setter}) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
