damccorm commented on code in PR #17341: URL: https://github.com/apache/beam/pull/17341#discussion_r859006987
########## sdks/typescript/src/apache_beam/internal/serialize.ts: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import * as serialize_closures from "serialize-closures"; +import Long from "long"; + +import { requireForSerialization, registeredObjects } from "../serialization"; + +const BIGINT_PREFIX = ":bigint:"; + +const generator = function* () {}; + +requireForSerialization("apache_beam", { + generator: generator, + generator_prototype: generator.prototype, + TextEncoder: TextEncoder, + TextDecoder: TextDecoder, + Long, +}); + +export function serializeFn(obj: unknown): Uint8Array { + return new TextEncoder().encode( + JSON.stringify( + serialize_closures.serialize( + obj, + serialize_closures.defaultBuiltins.concat(registeredObjects) + ), + (key, value) => + typeof value === "bigint" ? `${BIGINT_PREFIX}${value}` : value + ) + ); +} + +export function deserializeFn(s: Uint8Array): any { + return serialize_closures.deserialize( + JSON.parse(new TextDecoder().decode(s), (key, value) => + typeof value === "string" && value.startsWith(BIGINT_PREFIX) + ? BigInt(value.substr(BIGINT_PREFIX.length)) + : value + ), + serialize_closures.defaultBuiltins.concat(registeredObjects) + ); +} + +let fakeSerializeCounter = 0; +const fakeSerializeMap = new Map<string, any>(); + +function fakeSeralize(obj) { + fakeSerializeCounter += 1; + const id = "s_" + fakeSerializeCounter; + fakeSerializeMap.set(id, obj); + return new TextEncoder().encode(id); +} + +function fakeDeserialize(s) { + return fakeSerializeMap.get(new TextDecoder().decode(s)); +} Review Comment: ```suggestion ``` None of this is used AFAIK and even if it is it probably should be in a separate file for mocks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
