lostluck commented on code in PR #17347:
URL: https://github.com/apache/beam/pull/17347#discussion_r859358611


##########
sdks/go/pkg/beam/io/parquetio/parquetio.go:
##########
@@ -118,6 +122,19 @@ func (a *parquetReadFn) ProcessElement(ctx 
context.Context, filename string, emi
        return nil
 }
 
+// Write writes a PCollection<parquetStruct> to .parquet file.
+// Write expects a type t of struct with parquet tags
+// For example:
+// type Student struct {
+//   Name    string  `parquet:"name=name, type=BYTE_ARRAY, convertedtype=UTF8, 
encoding=PLAIN_DICTIONARY"`
+//   Age     int32   `parquet:"name=age, type=INT32, encoding=PLAIN"`
+//   Id      int64   `parquet:"name=id, type=INT64"`
+//   Weight  float32 `parquet:"name=weight, type=FLOAT"`
+//   Sex     bool    `parquet:"name=sex, type=BOOLEAN"`
+//   Day     int32   `parquet:"name=day, type=INT32, convertedtype=DATE"`
+//   Ignored int32   //without parquet tag and won't write
+// }
+

Review Comment:
   ```suggestion
   // }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to