chamikaramj commented on code in PR #17319:
URL: https://github.com/apache/beam/pull/17319#discussion_r861084554
##########
sdks/python/apache_beam/io/external/xlang_kafkaio_it_test.py:
##########
@@ -75,8 +75,8 @@ def build_write_pipeline(self, pipeline):
pipeline
| 'Generate' >> beam.Create(range(NUM_RECORDS)) # pylint:
disable=bad-option-value
| 'MakeKV' >> beam.Map(lambda x:
- (b'', str(x).encode())).with_output_types(
- typing.Tuple[bytes, bytes])
+ (None, str(x).encode())).with_output_types(
Review Comment:
Could we also add a version that uses a non-null non-empty key ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
