ryanthompson591 commented on PR #17496: URL: https://github.com/apache/beam/pull/17496#issuecomment-1112676641
@TheNeuralBit Originally, I felt the same. sklearn and pytorch, let me know if I'm wrong. The problem I was seeing was name collision. For example if someone had the following imports. import sklearn from apache_beam.ml.inference import sklearn there would be a name collision. Problem is that python does raise an exception here, but simply has the last import stand. So this will cause our users debugging head aches. Instead they would need to do something like. import sklearn import apache_beam.ml.inference.sklearn as apache_sklearn (or sklearn_inference or whatever) Our feeling is that users will often also import sklearn to use some of the libraries there. So in order to avoid error, we plan to use framework_inference as the name. I liked loader and andy liked inference. So we flipped a coin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
