andreigurau commented on code in PR #17477:
URL: https://github.com/apache/beam/pull/17477#discussion_r861805473
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java:
##########
@@ -156,6 +165,16 @@ static Schema getSchema(Class<? extends Message> clazz) {
}
static Schema getSchema(Descriptors.Descriptor descriptor) {
Review Comment:
I get why it may not be multi-thread safe, but why are you saying it is ok
to leave it as is? I will say that this change doesn't seem to fail any
existing tests
Also, I created a Javadoc for this function, but I doubt I did it correctly.
I'm not sure what the standards are exactly, but I tried to copy what I've seen
from other examples. Let me know if there's anything that needs to be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
