tvalentyn commented on code in PR #17498:
URL: https://github.com/apache/beam/pull/17498#discussion_r862333613
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -471,10 +471,19 @@ def run_pipeline(self, pipeline, options,
pipeline_proto=None):
options.view_as(WorkerOptions).sdk_container_image = (
self._default_environment.container_image)
else:
+ artifacts = environments.python_sdk_dependencies(options)
+ if artifacts and apiclient._use_fnapi(options):
+ _LOGGER.info(
+ "Pipeline has additional dependencies to be installed "
+ "in SDK worker container, consider using the SDK "
+ "container image pre-building workflow to avoid "
+ "repetitive installations. Learn more on "
+ "https://cloud.google.com/dataflow/docs/guides/";
+ "using-custom-containers#prebuild")
Review Comment:
Sounds very reasonable. Let's add references and structure that prevents
duplication. Such as: For using prebuilding with Google Cloud Dataflow, see ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
