harrydrippin opened a new pull request, #17518:
URL: https://github.com/apache/beam/pull/17518
This PR fixes BEAM-10785 by adding the `coder` argument from
`WriteToBigQuery` to `JsonRowWriter` to enable users to modify the coder for
various reasons on batch pipeline. The `coder` argument will be defaulted to
`RowAsDictJsonCoder` if user didn't specify.
This modification needs to add `coder` argument on below classes and
functions. This PR also applies changes for them.
* `BigQueryBatchFileLoads`
* `WriteRecordsToFile`
* `WriteGroupedRecordsToFile`
* `_make_new_file_writer()`
* `JsonRowWriter`
This version was tested on `DataflowRunner` and there were no any problems
while using custom coder. But this PR does not have any additional unit tests
now, so it will be great if reviewers can provide some directions about
appropriate unit tests. Please let me know if there are any concerns on this
PR. Thank you!
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
