andreigurau commented on code in PR #17477:
URL: https://github.com/apache/beam/pull/17477#discussion_r862871477
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java:
##########
@@ -126,6 +127,7 @@
* </ul>
*/
@SuppressWarnings({
+ "nullness", // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Review Comment:
Ok, I modified the code to use an empty Schema as a placeholder in the map,
instead of ```null```. Also, I added a unit test to show that the placeholder
empty Schema is not the same as an empty proto object, so it won't accidentally
throw an exception if an empty Schema is passed in to the ```getSchema```
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
