guillaumecle commented on code in PR #17274:
URL: https://github.com/apache/beam/pull/17274#discussion_r862224385
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -117,8 +121,12 @@ public static JavaVersion forSpecification(String
specification) {
return ver;
}
}
- throw new UnsupportedOperationException(
- String.format("unsupported Java version: %s", specification));
+ JavaVersion fallback = java11;
Review Comment:
I added a strict method `forSpecificationStrict`.
the java version ends up being used in
* `JAVA_SDK_HARNESS_CONTAINER_URL` for which I want to use the lenient
version for now
* `DataflowRunner.fromOptions` for which I want to use the lenient version
* `DataflowRunner.getDefaultContainerImageNameForJob` for which I want to
use the lenient version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
