robertwb commented on code in PR #17384: URL: https://github.com/apache/beam/pull/17384#discussion_r863277468
########## sdks/python/apache_beam/utils/windowed_value.pxd: ########## @@ -43,6 +43,23 @@ cdef class WindowedValue(object): cpdef WindowedValue with_value(self, new_value) +cdef class WindowedBatch(object): + cpdef WindowedBatch with_values(self, object new_values) + +cdef class HomogeneousWindowedBatch(WindowedBatch): + cdef public WindowedValue _wv Review Comment: Yeah, it doesn't know the type of other. I suppose making this public isn't any worse than plain-vanilla Python. (The alternative is to cast, but that is less clean with our hybrid works-in-pure-and-compiled mode.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
